Cleanup: nav handler, update banner IPC, updater setup, release swap, docs #12

Merged

adam merged 2 commits from ai/issue-9 into master

2026-10-03 12:01:26 -04:00

adam commented

2026-10-03 11:54:19 -04:00

Owner

Closes #9

One SUNBURN_ORIGIN const and one rememberUrl handler for did-navigate/did-navigate-in-page.
Updater no longer injects HTML via executeJavaScript; it sends an update-downloaded IPC event (re-sent on page load), exposed as sunburnDesktop.onUpdateDownloaded(cb) (returns unsubscribe).
setupAutoUpdater runs once in whenReady (window getter), not per window.
README release notes and .gitignore fixed.
Release workflow keeps the latest release and swaps assets in place (manifests uploaded as .new, then delete + rename) instead of delete/recreate.

Not done: Windows signing (needs a certificate and secrets plumbing into Dockerfile.release); should be its own issue. Old binaries are not pruned from latest.

Follow-up needed: the web app must subscribe to onUpdateDownloaded and render the banner; until then there's no banner (restart still works via settings/app quit).

Tested: node --check, YAML parse. Not run in Electron; release.yml only runs live on master and is idempotent on re-run.

🤖 Generated with Claude Code

Closes #9 - One `SUNBURN_ORIGIN` const and one `rememberUrl` handler for `did-navigate`/`did-navigate-in-page`. - Updater no longer injects HTML via `executeJavaScript`; it sends an `update-downloaded` IPC event (re-sent on page load), exposed as `sunburnDesktop.onUpdateDownloaded(cb)` (returns unsubscribe). - `setupAutoUpdater` runs once in `whenReady` (window getter), not per window. - README release notes and `.gitignore` fixed. - Release workflow keeps the `latest` release and swaps assets in place (manifests uploaded as `.new`, then delete + rename) instead of delete/recreate. **Not done:** Windows signing (needs a certificate and secrets plumbing into `Dockerfile.release`); should be its own issue. Old binaries are not pruned from `latest`. **Follow-up needed:** the web app must subscribe to `onUpdateDownloaded` and render the banner; until then there's no banner (restart still works via settings/app quit). **Tested:** `node --check`, YAML parse. Not run in Electron; release.yml only runs live on master and is idempotent on re-run. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

adam added 1 commit

2026-10-03 11:54:19 -04:00

Cleanup: single nav handler, IPC update banner, one-time updater setup, in-place release swap, stale docs (#9 ) e137dffb2c

adam changed title from ~~WIP: Cleanup: nav handler, update banner IPC, updater setup, release swap, docs~~ to Cleanup: nav handler, update banner IPC, updater setup, release swap, docs

2026-10-03 11:54:26 -04:00

adam referenced this pull request

2026-10-03 11:54:28 -04:00

Cleanup: nav handler dupe, update banner injection, stale docs, release gap #9

adam added 1 commit

2026-10-03 12:00:19 -04:00

Merge origin/master into ai/issue-9 64304e84ae

adam merged commit 6bb72c190d into master

2026-10-03 12:01:26 -04:00

adam deleted branch ai/issue-9

2026-10-03 12:01:26 -04:00

adam referenced this pull request from a commit