Cleanup: nav handler dupe, update banner injection, stale docs, release gap #9

New issue

Closed

opened 2026-10-03 09:24:08 -04:00 by adam · 2 comments

adam commented

2026-10-03 09:24:08 -04:00

Owner

did-navigate and did-navigate-in-page handlers are copy-pasted; hardcoded https://chat.galactica.host repeated — one const + one handler.
updater.js injects the update banner with executeJavaScript and interpolates info.version into HTML; send an IPC event and let the web app render it.
setupAutoUpdater is called per createWindow (adds listeners + a new setInterval each time).
README says CI "skips if latest already serves the current version" — it doesn't; it always bumps.
.gitignore still lists src-tauri/target/.
Release workflow deletes then recreates the latest release → updaters can 404 in between. Upload to a new release first, then swap.
Windows build is unsigned (SmartScreen warnings, no publisher verification for updates).

- `did-navigate` and `did-navigate-in-page` handlers are copy-pasted; hardcoded `https://chat.galactica.host` repeated — one const + one handler. - `updater.js` injects the update banner with `executeJavaScript` and interpolates `info.version` into HTML; send an IPC event and let the web app render it. - `setupAutoUpdater` is called per `createWindow` (adds listeners + a new `setInterval` each time). - README says CI "skips if latest already serves the current version" — it doesn't; it always bumps. - `.gitignore` still lists `src-tauri/target/`. - Release workflow deletes then recreates the `latest` release → updaters can 404 in between. Upload to a new release first, then swap. - Windows build is unsigned (SmartScreen warnings, no publisher verification for updates).

adam added the

cleanup

severity/low

labels

2026-10-03 09:24:08 -04:00

adam referenced this issue from a commit

2026-10-03 11:54:13 -04:00

Cleanup: single nav handler, IPC update banner, one-time updater setup, in-place release swap, stale docs (#9)

adam referenced this issue from a pull request that will close it,

2026-10-03 11:54:19 -04:00

Cleanup: nav handler, update banner IPC, updater setup, release swap, docs #12

adam commented

2026-10-03 11:54:28 -04:00

Author

Owner

Fixed by #12 (#12)

Fixed by #12 (https://git.galactica.host/adam/sunburn-desktop/pulls/12)

adam referenced this issue

2026-10-03 11:54:51 -04:00

Lock main window to the Sunburn origin #13

adam closed this issue

2026-10-03 12:01:26 -04:00

adam commented

2026-10-03 12:04:32 -04:00

Author

Owner

Checked HEAD (6bb72c1): six of seven bullets are done by #12. The remaining one, Windows code signing, needs a signing certificate or Azure Trusted Signing account plus secrets and a Dockerfile.release change, so it can't be fixed in code alone. Setting publisherName before builds are signed would make the updater reject every update. Suggest tracking signing in a new issue once a cert route is chosen. No PR opened.

Checked HEAD (6bb72c1): six of seven bullets are done by #12. The remaining one, Windows code signing, needs a signing certificate or Azure Trusted Signing account plus secrets and a Dockerfile.release change, so it can't be fixed in code alone. Setting publisherName before builds are signed would make the updater reject every update. Suggest tracking signing in a new issue once a cert route is chosen. No PR opened.