Add link-browser setting (#14) #15

Merged
adam merged 1 commit from ai/issue-14 into master 2026-10-04 21:01:32 -04:00
Owner

Closes #14

Adds a linkBrowser setting plus IPC (getLinkBrowser/chooseLinkBrowser/resetLinkBrowser) so the web Settings → Links picker works. http(s) links spawn the chosen binary, falling back to shell.openExternal on spawn error; mailto and unset use the system handler. Choose uses a native dialog (no renderer-supplied path); cancel returns the current value. Bumps to 1.5.0.

Tested: npm test (new test/links.test.js). Not run in Electron/AppImage. LD_LIBRARY_PATH is stripped from the child env as a precaution; unverified against the AppImage runtime. The xdg-open diagnosis follow-up from the issue is not included.

Closes #14 Adds a `linkBrowser` setting plus IPC (`getLinkBrowser`/`chooseLinkBrowser`/`resetLinkBrowser`) so the web Settings → Links picker works. http(s) links spawn the chosen binary, falling back to `shell.openExternal` on spawn error; mailto and unset use the system handler. Choose uses a native dialog (no renderer-supplied path); cancel returns the current value. Bumps to 1.5.0. Tested: `npm test` (new test/links.test.js). Not run in Electron/AppImage. `LD_LIBRARY_PATH` is stripped from the child env as a precaution; unverified against the AppImage runtime. The xdg-open diagnosis follow-up from the issue is not included.
adam changed title from WIP: Add link-browser setting (#14) to Add link-browser setting (#14) 2026-10-04 20:58:55 -04:00
adam merged commit 39030ee987 into master 2026-10-04 21:01:32 -04:00
adam deleted branch ai/issue-14 2026-10-04 21:01:32 -04:00
adam referenced this pull request from a commit 2026-10-04 21:01:33 -04:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
adam/sunburn-desktop!15
No description provided.